fix in the bezel for specific screen configuration#200
Merged
rdumusc merged 11 commits intoBlueBrain:masterfrom Oct 27, 2017
Merged
fix in the bezel for specific screen configuration#200rdumusc merged 11 commits intoBlueBrain:masterfrom
rdumusc merged 11 commits intoBlueBrain:masterfrom
Conversation
rdumusc
reviewed
Oct 25, 2017
| <div id="wall"> | ||
| <div id="wallOutline"></div> | ||
| <div id="wallLock"> | ||
| <img src="img/lock.svg" height="600" style="margin: 0 auto; position:relative; display:block; top: 25%"> |
| } | ||
|
|
||
| function setBezels() { | ||
| if ( displayHeight === 0 || displayWidth === 0) |
| $div.css("left", left); | ||
| else if (dir == 'N' || dir == 'S') | ||
| $div.css("left", centerH); | ||
| if (dir == 'E') |
ppodhajski
force-pushed
the
fix/bezel
branch
4 times, most recently
from
add9719 to
606537f
Compare
rdumusc
reviewed
Oct 27, 2017
rdumusc
left a comment
rdumusc
left a comment
There was a problem hiding this comment.
+1, just use uint instead of int for configuration values?
| @@ -1,5 +1,5 @@ | |||
| <configuration> | |||
| <dimensions mullionHeight="0" fullscreen="0" numTilesWidth="1" screenHeight="216" mullionWidth="0" screenWidth="1536" numTilesHeight="3"/> | |||
| <dimensions fullscreen="0" numScreensX="1" numScreensY="3" displayWidth="1536" displayHeight="216" displaysPerScreenX="3" bezelWidth="0" bezelHeight="0" /> | |||
There was a problem hiding this comment.
displaysPerScreenX="3" ? this makes it much bigger
| if (_displaysPerScreenY == 0 || _displaysPerScreenX == 0 || | ||
| _totalScreenCountY == 0 || _totalScreenCountX == 0 || | ||
| _displayWidth == 0 || _displayHeight == 0) | ||
| throw std::invalid_argument("tile index does not exist"); |
There was a problem hiding this comment.
try to have more accurate messages that help the user adjust his configuration.
rdumusc
approved these changes
Oct 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for the issue observed when X Server screen spans over multiple physical displays