PixelStream bugfix: do not set ContentSize to zero on empty SizeHints event#21
Merged
rdumusc merged 1 commit intoBlueBrain:masterfrom May 20, 2016
Merged
PixelStream bugfix: do not set ContentSize to zero on empty SizeHints event#21rdumusc merged 1 commit intoBlueBrain:masterfrom
rdumusc merged 1 commit intoBlueBrain:masterfrom
Conversation
Contributor
|
+1 |
Contributor
|
Changelog? |
Author
|
I can add a Changelog entry, but its a very small bugfix that probably nobody ever observed |
Author
|
done |
rdumusc
pushed a commit
to rdumusc/Tide
that referenced
this pull request
Jan 22, 2018
The bug was introduced in BlueBrain#21 by using a binary copy of MovieContent via Content::clone(). The binary copy did not (and should not) recreate the actions, as they are already serialized by Content when sending to the wall processes. They should only be created when making a new object on the master process, which includes loading from xml. Other minor cleanups, including creating the actions for PixelStreamContents only when loading from xml to be consistent, even though in this case the the order of the operations was different so the problem was not visible.
rdumusc
pushed a commit
that referenced
this pull request
Jan 23, 2018
The bug was introduced in #21 by using a binary copy of MovieContent via Content::clone(). The binary copy did not (and should not) recreate the actions, as they are already serialized by Content when sending to the wall processes. They should only be created when making a new object on the master process, which includes loading from xml. Other minor cleanups, including creating the actions for PixelStreamContents only when loading from xml to be consistent, even though in this case the the order of the operations was different so the problem was not visible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.