RestLogger and LoggingUtility implemented#39
Merged
dnachbaur merged 1 commit intoBlueBrain:masterfrom Jun 20, 2016
Merged
Conversation
|
Can one of the admins verify this patch? |
|
test this please |
| ) | ||
|
|
||
| list(APPEND TIDECORE_SOURCES | ||
| LoggingUtility.cpp |
Contributor
There was a problem hiding this comment.
the files are sorted alphabetically here, please keep that. Plus, the header file should be added to HEADERS above.
|
Can one of the admins verify this patch? |
Contributor
|
retest this please |
Contributor
|
The OSX build is failing. Either we add libzmq to .travis.yml, or add an ifdef around the code in tide master if rest interface is available. |
|
yes, it must be ifdef'ed properly. Actually there are already include guards and I don't understand how this fails |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added two classes meant to provide information on application usage.