This repository was archived by the owner on Jul 28, 2025. It is now read-only.
Conversation
Codecov Report
@@ Coverage Diff @@
## main #11 +/- ##
==========================================
- Coverage 75.64% 75.00% -0.65%
==========================================
Files 12 12
Lines 1474 1516 +42
Branches 231 239 +8
==========================================
+ Hits 1115 1137 +22
- Misses 296 315 +19
- Partials 63 64 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
|
So it looks almost good to me, you just have to edit the name of the PR to make it more descriptive and fix the tests. |
Collaborator
Author
|
yes yes, I just rebased, I'll fix it later |
Collaborator
Author
|
@adrien-berchet , I'm stuck here, pm me when you have time to look at it, basically in MakeRelease, the output column names depend on extension list user provide. I'm not sure we can do that, if not, we can have a simpler report.csv. |
Collaborator
Author
|
@adrien-berchet , forget it, I know how to fix |
Collaborator
Author
|
@lidakanari , try with this branch, it should make a release folder per extension |
adrien-berchet
changed the title
Co-authored-by: Adrien Berchet <adrien.berchet@epfl.ch>
Collaborator
Author
|
@adrien-berchet , good to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apart from minor fixes, it does: