Skip to content
This repository was archived by the owner on Jul 28, 2025. It is now read-only.

cleanup example#17

Merged
arnaudon merged 7 commits intomainfrom
clean_example
Mar 15, 2022
Merged

cleanup example#17
arnaudon merged 7 commits intomainfrom
clean_example

Conversation

@arnaudon
Copy link
Collaborator

@arnaudon arnaudon commented Mar 15, 2022

I moved the test example to test folder, as it's a bit messy with test morphologies, and created a cleaner example with morphologies from neuromorpho.org, as done in diameter-synthesis example.

@arnaudon arnaudon requested a review from adrien-berchet March 15, 2022 12:46
@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #17 (5c46212) into main (8dbf25a) will decrease coverage by 0.48%.
The diff coverage is 30.76%.

@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
- Coverage   74.54%   74.05%   -0.49%     
==========================================
  Files          11       11              
  Lines        1261     1272      +11     
  Branches      191      195       +4     
==========================================
+ Hits          940      942       +2     
- Misses        273      278       +5     
- Partials       48       52       +4     
Flag Coverage Δ
pytest 74.05% <30.76%> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/morphology_workflows/annotation.py 62.58% <0.00%> (-0.82%) ⬇️
src/morphology_workflows/curation.py 70.64% <33.33%> (-0.49%) ⬇️
src/morphology_workflows/repair.py 83.25% <37.50%> (-1.96%) ⬇️

@arnaudon
Copy link
Collaborator Author

@adrien-berchet , can we bypass codecov on that one? I just added a few if to bypass mtype stuff if there is no mtype

@adrien-berchet
Copy link
Member

@adrien-berchet , can we bypass codecov on that one? I just added a few if to bypass mtype stuff if there is no mtype

Yeah it's no big deal. I think I can force merge, can't you?

@arnaudon arnaudon merged commit f43964e into main Mar 15, 2022
@arnaudon arnaudon deleted the clean_example branch March 15, 2022 13:44
@arnaudon
Copy link
Collaborator Author

Yes, I could merge!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants