Skip to content
This repository was archived by the owner on Jul 28, 2025. It is now read-only.

Add workflow to compute placeholders#22

Merged
arnaudon merged 4 commits intomainfrom
placeholders
Jul 1, 2022
Merged

Add workflow to compute placeholders#22
arnaudon merged 4 commits intomainfrom
placeholders

Conversation

@adrien-berchet
Copy link
Member

No description provided.

@adrien-berchet adrien-berchet force-pushed the placeholders branch 3 times, most recently from b5de597 to 6677e00 Compare May 5, 2022 11:55
@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #22 (6169f29) into main (5341c64) will increase coverage by 0.26%.
The diff coverage is 93.05%.

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   86.10%   86.37%   +0.26%     
==========================================
  Files          12       14       +2     
  Lines        1497     1563      +66     
  Branches      238      245       +7     
==========================================
+ Hits         1289     1350      +61     
- Misses        132      134       +2     
- Partials       76       79       +3     
Flag Coverage Δ
pytest 86.37% <93.05%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/morphology_workflows/tasks/workflows.py 95.65% <ø> (-0.13%) ⬇️
src/morphology_workflows/placeholders.py 90.00% <90.00%> (ø)
src/morphology_workflows/tasks/placeholders.py 92.30% <92.30%> (ø)
src/morphology_workflows/tasks/cli.py 78.29% <100.00%> (+0.34%) ⬆️
src/morphology_workflows/tasks/fetch.py 86.95% <100.00%> (+1.24%) ⬆️

@adrien-berchet
Copy link
Member Author

This PR works with the master branch of NeuroM (tried with BlueBrain/NeuroM@0ca89b0) but we will need a new release before merging this.

@arnaudon
Copy link
Collaborator

arnaudon commented Jul 1, 2022

is this to be reviewed?

@adrien-berchet
Copy link
Member Author

Yep
I just rebased on the main branch so it is supposed to be ready to be reviewed.

Copy link
Collaborator

@arnaudon arnaudon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good with me, it's basically just using neurom morph_stats, right?

@adrien-berchet
Copy link
Member Author

good with me, it's basically just using neurom morph_stats, right?

Yeah exactly, it just calls it with a default config or a config given by the user.

@arnaudon arnaudon merged commit c1d3ad7 into main Jul 1, 2022
@arnaudon arnaudon deleted the placeholders branch July 1, 2022 16:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants