Duplicate layers

[arnaudon]

No description provided.

[codecov]

Codecov Report

Merging #60 (aaba032) into main (6a957c8) will decrease coverage by 0.22%.
The diff coverage is 81.63%.

@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
- Coverage   86.25%   86.03%   -0.23%     
==========================================
  Files          14       14              
  Lines        1579     1611      +32     
  Branches      251      258       +7     
==========================================
+ Hits         1362     1386      +24     
- Misses        136      141       +5     
- Partials       81       84       +3     

Flag	Coverage Δ
pytest	86.03% <81.63%> (-0.23%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/morphology_workflows/repair.py	79.31% <81.25%> (-0.69%)	⬇️
src/morphology_workflows/tasks/repair.py	100.00% <100.00%> (ø)

[arnaudon]

@adrien-berchet , in the last commit, I try to save the df with extra duplicated rows, with ValidationResultSet, but it does not seem to work. Do you have an idea how to do?

[arnaudon]

and if possible of course

[adrien-berchet]

What do you mean by "not work"?

[arnaudon]

Something is a little weird, the df needs to be modified in place, even if I return the ValidationResultSet.
Also, if I change the df size in place, it crashes dvf, you even have put a raise to prevent bad crash, so I had to trick things here a little.

[adrien-berchet]

Ah yeah, remember that the philosophy of DVF is to validate existing data, not creating new data. For example in the cloning step we don't add the clones in the DF, we only add them in the neurondb file. If you want to create new data you could create a column containing a list of the results that were created from the current row for example.

[arnaudon]

yep, so let's do something like I did here, let me know if it's good, so we can merge and update clone the same way (I created MR for it already)

[arnaudon]

@adrien-berchet , this does not work, as there is a loop over extensions, and we do several times the iterrows over the df_tmp, which does not have the values for previous extensions...

[arnaudon]

ok, now it works, it's not very clean, but it's fine for now, unless you want to try to improve