Skip to content

Enabled resolvers mapping files to contains rules calling a forge method#323

Merged
MFSY merged 2 commits into
masterfrom
fix_316
Aug 10, 2023
Merged

Enabled resolvers mapping files to contains rules calling a forge method#323
MFSY merged 2 commits into
masterfrom
fix_316

Conversation

@MFSY
Copy link
Copy Markdown
Collaborator

@MFSY MFSY commented Jul 18, 2023

Fixes #316

@MFSY MFSY requested a review from crisely09 July 19, 2023 19:46
Copy link
Copy Markdown
Contributor

@crisely09 crisely09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an example or a test? do we have already a case where the hjson has a forge function?

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #323 (20ae01b) into master (172fc34) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #323   +/-   ##
=======================================
  Coverage   72.62%   72.62%           
=======================================
  Files          90       90           
  Lines        5761     5761           
=======================================
  Hits         4184     4184           
  Misses       1577     1577           
Flag Coverage Δ
unittests 72.62% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
kgforge/core/archetypes/resolver.py 64.39% <0.00%> (ø)
kgforge/core/forge.py 65.38% <ø> (ø)

@MFSY
Copy link
Copy Markdown
Collaborator Author

MFSY commented Aug 7, 2023

Could you add an example or a test?

This is to match how mappers are invoked in this merged PR https://github.com/BlueBrain/nexus-forge/pull/315/files#diff-c86c44807067dc2a80f4c2bcfa7aa9ec26c580888cc7fbba71032bb14736c73f.

A forge instance should be passed when calling mapper(forge).map()

do we have already a case where the hjson has a forge function?

There is not yet a configured resolver with a mapping file using a forge method. But this is a matter of time.

@MFSY MFSY merged commit a1f7242 into master Aug 10, 2023
@MFSY MFSY deleted the fix_316 branch August 10, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support result_resource_mapping with forge calls in Resolver.resolve()

3 participants