Update test directory references from test_dir to tests #26
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @ipv1337, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request focuses on updating the codebase to reflect the change in the test directory structure, moving from test_dir/ to tests/. I've updated configuration files, documentation, scripts, and test files to reflect this change. The primary goal is to ensure that the test suite runs correctly and that coverage reports are accurate after the directory change.
Highlights
- Configuration Update: Updated
.coveragercandpyproject.tomlto point to the newtests/directory for coverage and linting configurations. - Documentation Update: Modified
docs/TESTING.mdto reflect the new test directory structure and remove references to the oldtest_dir/. - Script Update: Adjusted
scripts/run_core_tests.shandscripts/run_coverage.shto use thetests/directory when running tests. - Test File Update: Updated test file paths in
tests/models/test_ollama_model_context.pyandtests/tools/test_tree_tool_edge_cases.pyto reflect the new location.
Changelog
Click here to see the changelog
- .coveragerc
- Removed
test_dir/from the omit list and ensuredtests/is included. - No newline at end of file was removed.
- Removed
- docs/TESTING.md
- Updated the testing structure documentation to reflect the move to the
tests/directory. - Removed the mention of the
test_dir/directory. - Minor formatting and wording adjustments for clarity.
- Updated the testing structure documentation to reflect the move to the
- pyproject.toml
- Updated
testpathsundertool.pytest.ini_optionsto point totests/. - Updated
per-file-ignoresto apply totests/*instead oftest_dir/*. - Reordered exclude list to group env and venv entries together.
- Updated omit list to remove
*/test_*and includetests/*
- Updated
- scripts/run_core_tests.sh
- Updated the script to point to the new test file locations under the
tests/directory. - No newline at end of file was removed.
- Updated the script to point to the new test file locations under the
- scripts/run_coverage.sh
- Updated the script to run coverage on the
tests/directory instead oftest_dir/. - No newline at end of file was removed.
- Updated the script to run coverage on the
- tests/models/test_ollama_model_context.py
- Updated the file path in the docstring to reflect the new location in the
tests/directory.
- Updated the file path in the docstring to reflect the new location in the
- tests/tools/test_tree_tool_edge_cases.py
- Updated the file path in the docstring to reflect the new location in the
tests/directory.
- Updated the file path in the docstring to reflect the new location in the
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A directory's changed,
Tests now live in 'tests/',
Codebase finds its way.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This PR updates test directory references from test_dir to tests. The changes look good overall, ensuring consistency across the project. However, there are a few minor points that could be improved for clarity and maintainability.
Summary of Findings
- Documentation Updates: The documentation updates in
docs/TESTING.mdare generally good, but some sentences could be rephrased for better clarity. - Script Updates: The script updates in
scripts/run_core_tests.shandscripts/run_coverage.shcorrectly update the test paths. Ensure that these scripts are thoroughly tested after the changes. - Test File Comments: The comments in the test files are updated to reflect the new test directory structure. Consider standardizing the comment style for consistency.
Merge Readiness
The pull request is almost ready for merging. Addressing the comments related to documentation clarity and ensuring the scripts are thoroughly tested would make it ready for merging. I am unable to approve this pull request, and recommend that others review and approve this code before merging.
|
|
||
| - `test_dir/`: Contains most test files | ||
| - `tests/`: Contains all test files, organized by module (e.g., `tests/models`, `tests/tools`). | ||
| Tests are organized in the `tests/` directory, organized by module (e.g., `tests/models`, `tests/tools`). |
There was a problem hiding this comment.
Consider rephrasing this sentence for better readability. For example, 'Tests are organized within the tests/ directory, categorized by module (e.g., tests/models, tests/tools).'
Code Coverage Report📊 Current Coverage: 90.46% Detailed coverage analysis is available in SonarCloud Coverage Change DetailsThis shows code coverage for changes in this PR. To improve coverage, consider adding tests for new or modified code. |
|
This PR updates references to the test directory throughout the codebase. Since tests now live in the
tests/directory instead oftest_dir/, this PR updates references in configuration files, documentation, scripts, and test files.