TEST: Update RotateSampleRefFrame unit test to also test 45 & 180 in all directions#1465
Merged
imikejackson merged 1 commit intoNov 10, 2025
Conversation
…rections. Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>
imikejackson
approved these changes
Nov 10, 2025
imikejackson
added a commit
that referenced
this pull request
May 4, 2026
Batch B covers rotations, orientation conversion, IPF coloring, and threshold logic. All reports remain DRAFT pending developer review of the tentative Algorithm Relationship and Oracle classifications. * RotateSampleRefFrameFilter (SimplnxCore) — flags the stale "only 90/180 deg verified" doc warning (45 deg tests were added in PR #1465); both v2 and v3 test archives still listed in CMakeLists; rotation math lives in shared ImageRotationUtilities * RotateEulerRefFrameFilter (OrientationAnalysis) — PR #1472 silently widened the per-voxel arithmetic from float to double precision (OrientationF -> *DType, Matrix3fR -> Matrix3dR); strongest deviation candidate vs legacy SIMPL * ComputeIPFColorsFilter (OrientationAnalysis) — PR #1472 (EbsdLib 2.0.0 bump) flagged as prime RGB-drift suspect; coverage is cubic-high + [001] only; existing diagnostic block in test asserts nothing * ConvertOrientationsFilter (OrientationAnalysis) — PR #1472 was a wholesale rewrite (~+387/-1190 net) of the dispatch and math layer, not a rename; PR #1438 hides a real algorithmic fix (getPositiveOrientation + zero-init); no exemplar archive; Stereographic excluded from cross-product; no round-trip test * MultiThresholdObjectsFilter (SimplnxCore) — suspected real bug: std::reverse is used in the replaceInput && inverse branch where boolean NOT appears to be intended; non-linear extraction story (#1301 stub -> #1521 not_used -> #1544 populated); dual-source SIMPL port consolidating MultiThresholdObjects v1 + v2 Cross-cutting: PR #1472 (EbsdLib 2.0.0) is materially significant for any filter that delegates math to EbsdLib and should be promoted out of the pruned list for those filters going forward. Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Rotate_Sample_Ref_Frame_Test_v2.tar.gz needs to be removed from the DataArchive after this PR gets approved and merged in.