DOC: Fix filter documentation and documentation related code bugs#1547
Merged
imikejackson merged 6 commits intoBlueQuartzSoftware:developfrom Mar 11, 2026
Merged
Conversation
d1809c0 to
fd08229
Compare
adb24b8 to
11d7298
Compare
nyoungbq
reviewed
Mar 10, 2026
Contributor
nyoungbq
left a comment
There was a problem hiding this comment.
@imikejackson documentation looks good, just remove the summary and todo files, and optionally update .gitignore if you plan to use the naming convention long term. I will approve as soon as they have been removed or justified
11d7298 to
c21cc07
Compare
c21cc07 to
070a085
Compare
nyoungbq
reviewed
Mar 10, 2026
Contributor
nyoungbq
left a comment
There was a problem hiding this comment.
missed rebase/merge artifacts
nyoungbq
approved these changes
Mar 10, 2026
Audit all ~152 SimplnxCore filter docs against C++ implementations. Fix 4 code bugs (missing commas in defaultTags() causing string concatenation, inconsistent # tag prefixes), 17 doc title mismatches vs humanName(), 11 major description inaccuracies, 8 medium severity doc issues, 4 data type range errors, and remove 1 orphan duplicate doc file. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…s() bugs Audit all 54 OrientationAnalysis filter docs against C++ implementations. Fix 2 code bugs (#-prefixed tags in AlignSectionsMutualInformationFilter, "Phae" typo in CreateEnsembleInfoFilter), 8 doc title mismatches vs humanName(), 27 doc Group/Subgroup mismatches vs defaultTags(), and remove 1 orphan doc file (GeneratePoleFigureFilter.md). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Audit all 88 ITKImageProcessing filter docs against C++ implementations. Fix 5 doc title mismatches (extraneous parenthetical suffixes), 3 description inaccuracies (wrong filter operations from copy-paste errors), 2 Group/Subgroup mismatches, and 1 doc format/footer inconsistency. Note: ITKBoundedReciprocalImageFIlter.cpp filename typo not renamed (CMake risk); flagged for manual attention. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3cba6e6 to
8952dad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
defaultTags()(missing commas causing string concatenation,#-prefixed tags, typo"Phae"→"Phase")humanName()defaultTags()(e.g.,"Crystallographic"→"Crystallography", wrong group names)UncertainRegularGridSampleSurfaceMesh.md,GeneratePoleFigureFilter.md)78 files changed across 2 commits (6 C++ source files, 70 markdown doc files, TODO.md, SUMMARY.md).
Test plan
humanName()anddefaultTags()in the corresponding C++ source🤖 Generated with Claude Code