ENH: Add missing cancel checks to lots of filters#1582
Merged
imikejackson merged 1 commit intoApr 8, 2026
Conversation
nyoungbq
approved these changes
Apr 8, 2026
Contributor
nyoungbq
left a comment
nyoungbq
left a comment
There was a problem hiding this comment.
All looks good, I was torn on the AlignGeometries changes on whether that cancel should be in the functions within the individual switch cases at the top level loop, but I do think that the loops would possibly suffer a minor slowdown and a single walk and read with no serious calculations shouldn't be too long for in-core applications so I am okay leaving it as is.
Side Note: Out of the scope of this PR, but align geometries could really use some user feedback around those functions. Not progress feedback in the loops in the function itself since that is basically a worse case senario for how much of the workload would be messaging, but notices for "Finding moving Centroid...", "Finding target Centroid...", "Beginning translation...", etc.
imikejackson
added a commit
that referenced
this pull request
May 4, 2026
Batch C covers orientation/c-axis math filters in OrientationAnalysis. All reports remain DRAFT pending developer review of the tentative Algorithm Relationship and Oracle classifications. * ComputeAvgOrientationsFilter — PR #1577 added vMF and Watson EM-based averaging methods; the filter now hosts three distinct algorithms under one UUID. v2 exemplars for the new methods are likely self-referential (added in the same PR). PR #1472 downgraded to pruned after scoped diff inspection (API rename only for this filter). * ComputeAvgCAxesFilter — PR #1438 silently changed three things: float-to-double accumulation, antipodal-flip behavior via counter reorder, and error-code renumbering. Exemplar 7_2_AvgCAxis.tar.gz is likely circular (regenerated post-fix). Mixed-phase warning path and counter==0 rescue path uncovered. * ComputeCAxisLocationsFilter — PR #1472 silently rewrote the qu-to-om path through a different EbsdLib API (Quaternion::toOrientationMatrix vs explicit qu2om), proposed as Deviation D4 pending comparison. PR #1582 cancel path returns success while leaving output partially zero-filled (D3 internal correctness issue). * ComputeFeatureReferenceCAxisMisorientationsFilter — PR #1438 has an explicit REV: review tag and StdDev double-precision fix that per the PR description brings output into agreement with DREAM3D > 6.5.172, but the change is not regression-locked by any new test in the same PR. * ComputeFeatureNeighborMisorientationsFilter — suspected port-fidelity bug: tempMisoList = featureNeighborList.size() is reassigned inside the inner j-loop, so the divisor reflects only the last neighbor's match state instead of a true matched-phase count. The ComputeAvgMisors=true test is an [.][UNIMPLEMENTED] stub, so the entire average-misorientation control flow has zero CI coverage. Cross-cutting: PR #1438 is the largest hidden-deviation hotspot surfaced in the audit so far — its "ENH" label is misleading; the PR was actually a correctness sweep with multiple silent algorithmic shifts. Multiple exemplar archives in this batch appear to be circular (regenerated from post-fix SIMPLNX output), so existing tests cannot prove legacy conformance even where they appear to. Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.