Implement BFAST Monitor Workflow#74
Conversation
Implements the BFAST Monitor algorithm for change detection. This patch replaces the placeholder scaffolding with a complete implementation using Ordinary Least Squares (OLS) to fit a harmonic model and an OLS-MOSUM process to detect breaks. Key changes: - Replaced the `ndarray-linalg` dependency with `nalgebra` to avoid linker issues with OpenBLAS. - Implemented the full OLS harmonic model fitting and prediction logic. - Implemented the OLS-MOSUM change detection process. - Updated the Python wrapper and type stubs to match the new Rust function signature. - Added a comprehensive test case to validate the implementation.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Implements the BFAST Monitor algorithm for change detection. This patch replaces the placeholder scaffolding with a complete implementation using Ordinary Least Squares (OLS) to fit a harmonic model and an OLS-MOSUM process to detect breaks. Key changes: - Replaced the `ndarray-linalg` dependency with `nalgebra` to avoid linker issues with OpenBLAS. - Implemented the full OLS harmonic model fitting and prediction logic. - Implemented the OLS-MOSUM change detection process. - Updated the Python wrapper and type stubs to match the new Rust function signature. - Added a comprehensive test case to validate the implementation. - Fixed clippy warnings for `unnecessary_cast` and `too_many_arguments`.
BnJam
merged commit f90e208
into
feat/bfast-monitor-scaffold-10782325817424901614
1 participant
This patch implements the BFAST Monitor algorithm, replacing the placeholder scaffolding with a complete implementation using a pure-Rust linear algebra library to avoid linker issues.
PR created automatically by Jules for task 10071568848564471051 started by @BnJam