ci: move permissions from job to workflow level#65
Conversation
Walkthrough2つのGitHub Actionsワークフロー( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/test.yml (1)
12-14: 最小権限へ調整: id-token: write は現状不要そうですこのワークフロー内でOIDC(例:
aws-actions/configure-aws-credentials等)は未使用のため、id-token: writeをworkflow全体に付与する必要はなさそうです。将来OIDCが必要になった場合は、そのジョブにのみJob単位で付与してください。workflowトップで権限を広げると、将来追加される全ジョブに波及します。提案diff:
permissions: contents: read - id-token: write.github/workflows/keepalive.yml (1)
12-14: 妥当:gh workflow enable用のactions: write付与。ただし意図コメントの追記を推奨
gh workflow enableにはactions: writeが必要なため設定は妥当です。将来の保守性向上のため、意図をコメントで明示しておくと安心です(他ジョブ追加時は、不要ならジョブ側でより厳しく上書きしてください)。permissions: + # gh workflow enable コマンドに必要 actions: write
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
.github/workflows/keepalive.yml(1 hunks).github/workflows/test.yml(1 hunks)
ワークフロー全体にパーミッション設定を移動しました。
Summary by CodeRabbit