fix: repair response model construction and type definitions#2
Merged
fix: repair response model construction and type definitions#2
Conversation
- Add missing fee field to SupportedResponse in X402Facilitator.supported() - Add missing scheme and asset fields to TypeScript FeeQuoteResponse - Make SupportedResponse.fee required in TypeScript (match Python) - Add network field to SettleResponse error paths in facilitator and server - Increase facilitator HTTP client timeout from 30s to 120s for GasFree settlement
The fee field on SupportedResponse was a single value for multiple kinds, which is architecturally incorrect. Aligns with coinbase/x402 which has no fee field on SupportedResponse. Fee info is provided per-request via /fee/quote endpoint instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feefield:X402Facilitator.supported()constructedSupportedResponsewithout the requiredfeefield, causing 500 on/supportedendpointschemeandassetfields that Python facilitator returnsnetwork: BothX402Facilitator.settle()andX402Server.settle_payment()omittednetworkin error responsesTest plan