feat(assistant-editor): tailor chat input controls for the preview#381
Merged
philmerrell merged 1 commit intoMay 23, 2026
Merged
Conversation
The assistant editor preview now hides voice mode and the settings button — neither is wired to anything useful inside the editor — while exposing file attachments so authors can test their assistant against the same inputs end users will send. File uploads flow through the existing /chat/stream proxy as file_upload_ids. Splits the chat-input settings button into its own showSettingsControl gate (previously coupled to showFileControls), adds a parallel showVoiceControl, and threads both through ChatContainerConfig. Renames the chat-input file input id to chat-input-file-upload to avoid colliding with the assistant form's knowledge-base file input on the editor page. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fileUploadIdsfrom the preview chat input throughPreviewChatServiceto/chat/streamasfile_upload_ids(mirrors the field name used by the main chat).showSettingsControlgate (previously coupled toshowFileControls) and add a parallelshowVoiceControl. Both threaded throughChatContainerConfigso all chat-input call sites can opt in/out independently.<input>id tochat-input-file-uploadto avoid colliding with the assistant form's existing knowledge-base file input (both previously usedid="file-upload", which became a duplicate on the editor page once attachments were re-enabled in the preview).Notable choices
.pptx; the KB upload includes.pptxand no images. Unifying them is a separate decision.PreviewChatService.sendMessagegains a 4th optionalfileUploadIdsarg; the request body only addsfile_upload_idswhen files are present.Test plan
+attach button but no mic and no settings/sliders.file_upload_idsmade it through)./session(new chat), confirm all four controls remain visible: attach, settings, mic, send.+separately — each opens with its own (different) accept list, no duplicate-id console warnings.🤖 Generated with Claude Code