Skip to content

Conversation

@1baga
Copy link
Contributor

@1baga 1baga commented Feb 9, 2019

Added a simple way to convert an Integer to a string and vice versa. Useful when you are making quick conversions to be put in one line of code. Also added the modulus math operation.

screenshot from 2019-02-09 21-46-46

Copy link
Owner

@BolajiAyodeji BolajiAyodeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
You need to run some fixes first.

  • Your Integer to String conversion doesn't seem to work, I get 34 instead of "34"
  • You should use the camel case style to name your variables
    age_toString should be ageToString
    length_toInt should be lengthToInt

Copy link
Owner

@BolajiAyodeji BolajiAyodeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Change the variable name from modulus to findModulus

@BolajiAyodeji
Copy link
Owner

Looks great!
Change the variable name from modulus to findModulus

You haven't made this change @1baga

@1baga
Copy link
Contributor Author

1baga commented Feb 9, 2019

Looks great!
Change the variable name from modulus to findModulus

You haven't made this change @1baga

done

Copy link
Owner

@BolajiAyodeji BolajiAyodeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Thank you.

@BolajiAyodeji BolajiAyodeji merged commit 50ce9a1 into BolajiAyodeji:master Feb 9, 2019
@BolajiAyodeji
Copy link
Owner

@all-contributors please add @1baga for code

@allcontributors
Copy link
Contributor

@BolajiAyodeji

I've put up a pull request to add @1baga! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants