Replace entity.link with a root relative link in actionShowLinkSelector#1312
Closed
maantje wants to merge 1 commit intoBookStackApp:masterfrom
Closed
Replace entity.link with a root relative link in actionShowLinkSelector#1312maantje wants to merge 1 commit intoBookStackApp:masterfrom
maantje wants to merge 1 commit intoBookStackApp:masterfrom
Conversation
Making the links from insert Entity link in the markdown editor root relative will make it that they won't break when changing domains.
Member
|
Thanks for offering this pull request @maantje. Unfortunately I'm going to reject this pull request due to the following:
Apologies if you find my response disappointing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making the links from insert Entity link in the markdown editor root relative will make it that the links won't break when changing domains.