Skip to content

Replace entity.link with a root relative link in actionShowLinkSelector#1312

Closed
maantje wants to merge 1 commit intoBookStackApp:masterfrom
maantje:patch-1
Closed

Replace entity.link with a root relative link in actionShowLinkSelector#1312
maantje wants to merge 1 commit intoBookStackApp:masterfrom
maantje:patch-1

Conversation

@maantje
Copy link
Contributor

@maantje maantje commented Mar 5, 2019

Making the links from insert Entity link in the markdown editor root relative will make it that the links won't break when changing domains.

Making the links from insert Entity link in the markdown editor root relative will make it that they won't break when changing domains.
@ssddanbrown
Copy link
Member

Thanks for offering this pull request @maantje.

Unfortunately I'm going to reject this pull request due to the following:

  • While this change may work on simple BookStack installs the URL logic is more complex and this would break on some other setups, Such as installs that are on the sub-path of a domain (https://example.com/docs/) for example.
  • I would prefer to keep the URL strategy consistent throughout BookStack, and there are a lot more places where URL's are used. You can find my thoughts on moving to relative URL's in pull request Dynamic Links and Editor Integration #1275.

Apologies if you find my response disappointing.

@ssddanbrown ssddanbrown closed this Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants