Skip to content

Fix overflow issue of page content#1779

Closed
LeonLiuY wants to merge 1 commit intoBookStackApp:masterfrom
LeonLiuY:LeonLiuY-fix-page-overflow
Closed

Fix overflow issue of page content#1779
LeonLiuY wants to merge 1 commit intoBookStackApp:masterfrom
LeonLiuY:LeonLiuY-fix-page-overflow

Conversation

@LeonLiuY
Copy link

Currently a long table in a page will overflow the white card background, since overflow: initial means overflow: visible.

Currently a long table in a page will overflow the white card background, since `overflow: initial` means `overflow: visible`.
@ssddanbrown
Copy link
Member

Thanks for offering this @LeonLiuY and apologies for my really late reply.

Unfortunately I don't think this is the right solution to the problem.
Although this prevents such pages from looking broken I think it's more important that the content is accessible to users rather than being completely cut off. Additionally, this would interfere with floating elements such as the content selection popup.

Ideally, I want to implement to a long-term solution that hides overflowing content while keeping it accessible.

Therefore I'll close off this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants