added port for bookstack-test#1808
Closed
richardhulbert wants to merge 1 commit intoBookStackApp:masterfrom
Closed
added port for bookstack-test#1808richardhulbert wants to merge 1 commit intoBookStackApp:masterfrom
richardhulbert wants to merge 1 commit intoBookStackApp:masterfrom
Conversation
Member
|
Hi @richardhulbert, I'd prefer not to share any variables across testing and non-testing config, especially in this case where there's additional logic to parse out the port for backwards compatibility in production, to prevent confusion when actively testing. Therefore I'm going to close off this pull request without merging. As of the current master branch, There is a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Dan
For those of us who might test using a mySQL db on a port other than 3306
Richard