Skip to content

added port for bookstack-test#1808

Closed
richardhulbert wants to merge 1 commit intoBookStackApp:masterfrom
richardhulbert:fix_testing_database_missing_port
Closed

added port for bookstack-test#1808
richardhulbert wants to merge 1 commit intoBookStackApp:masterfrom
richardhulbert:fix_testing_database_missing_port

Conversation

@richardhulbert
Copy link

Hi Dan

For those of us who might test using a mySQL db on a port other than 3306

Richard

@ssddanbrown
Copy link
Member

Hi @richardhulbert,
Thank you for offering this pull request.

I'd prefer not to share any variables across testing and non-testing config, especially in this case where there's additional logic to parse out the port for backwards compatibility in production, to prevent confusion when actively testing. Therefore I'm going to close off this pull request without merging.

As of the current master branch, There is a TEST_DATABASE_URL env option available. You can set this in the format mysql://username:password@host:port/database which allows you use a custom port and even a custom database name. This will probably be the preferred approach to customising these testing options from now on.

@ssddanbrown ssddanbrown closed this Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants