Skip to content

Add BookRevision#1816

Closed
FrodeMMeling wants to merge 1 commit intoBookStackApp:masterfrom
FrodeMMeling:feature/add_book_revision
Closed

Add BookRevision#1816
FrodeMMeling wants to merge 1 commit intoBookStackApp:masterfrom
FrodeMMeling:feature/add_book_revision

Conversation

@FrodeMMeling
Copy link

@FrodeMMeling FrodeMMeling commented Dec 11, 2019

This is still WIP

Just wondering if this is something you would consider merging?
This will make it possible to create Book revisions, not only Page revisions.

Todo:

  • Add Chapters also to Book revision
  • What to do if no Pagerevision exist. Force create ?
  • Add basic GUI
  • Add testing

Future features:

  • Diff comparisons between BookRevisions
  • Guest users to request changes on Book level (group of pages changed). Like a pull request on git.
    ...

@ssddanbrown
Copy link
Member

Hi @FrodeMMeling,
Sorry for the mega long response time.

As it stands this is currently not something I'd consider merging. I can't currently really see the benefits to existing BookStack users with implementing Book Revisions. Really, It's just the name and description that's actually contained within the book. Implementing full revisioning including the included content of a book, which may have some use, will be a logical nightmare , especially as you consider the permissions system, requiring a lot of code and, more importantly, maintenance effort around those core BookStack elements.

@FrodeMMeling
Copy link
Author

FrodeMMeling commented Sep 19, 2020 via email

@tcatlas tcatlas mentioned this pull request Sep 22, 2020
@wojosc
Copy link

wojosc commented Sep 22, 2020

Also full history for the levels book and even shelf would be useful.

@ssddanbrown
Copy link
Member

Will therefore close based on the above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants