Add BookRevision#1816
Closed
FrodeMMeling wants to merge 1 commit intoBookStackApp:masterfrom
FrodeMMeling:feature/add_book_revision
Closed
Add BookRevision#1816FrodeMMeling wants to merge 1 commit intoBookStackApp:masterfrom FrodeMMeling:feature/add_book_revision
FrodeMMeling wants to merge 1 commit intoBookStackApp:masterfrom
FrodeMMeling:feature/add_book_revision
Conversation
Member
|
Hi @FrodeMMeling, As it stands this is currently not something I'd consider merging. I can't currently really see the benefits to existing BookStack users with implementing Book Revisions. Really, It's just the name and description that's actually contained within the book. Implementing full revisioning including the included content of a book, which may have some use, will be a logical nightmare , especially as you consider the permissions system, requiring a lot of code and, more importantly, maintenance effort around those core BookStack elements. |
Author
|
Ok. We will implement it ourselves then. We do not use it for books, but for technical specs. Then this revisioning is very handy. Thanks for the response.
Frode Marton Meling
IT Manager
Salt Ship Design
…________________________________
Fra: Dan Brown <notifications@github.com>
Sendt: Saturday, September 19, 2020 1:37:44 PM
Til: BookStackApp/BookStack <BookStack@noreply.github.com>
Kopi: Frode Marton Meling <fm@saltship.com>; Mention <mention@noreply.github.com>
Emne: Re: [BookStackApp/BookStack] Add BookRevision (#1816)
Hi @FrodeMMeling<https://github.com/FrodeMMeling>,
Sorry for the mega long response time.
As it stands this is currently not something I'd consider merging. I can't currently really see the benefits to existing BookStack users with implementing Book Revisions. Really, It's just the name and description that's actually contained within the book. Implementing full revisioning including the included content of a book, which may have some use, will be a logical nightmare , especially as you consider the permissions system, requiring a lot of code and, more importantly, maintenance effort around those core BookStack elements.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#1816 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AA2UB67OESIVPESK2KLY3ZLSGSJYRANCNFSM4JZMWCQA>.
|
Closed
|
Also full history for the levels book and even shelf would be useful. |
Member
|
Will therefore close based on the above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is still WIP
Just wondering if this is something you would consider merging?
This will make it possible to create Book revisions, not only Page revisions.
Todo:
Future features:
...