Allow users to create roles when creating users#2299
Closed
timoschwarzer wants to merge 1 commit intoBookStackApp:masterfrom
Closed
Allow users to create roles when creating users#2299timoschwarzer wants to merge 1 commit intoBookStackApp:masterfrom
timoschwarzer wants to merge 1 commit intoBookStackApp:masterfrom
Conversation
Member
|
Thanks @timoschwarzer for providing this and apologies for my late feedback. While I can definitely see the use-case/benefits for some people at the moment, this is not a feature that I'd specifically want to add. Realistically per-user roles are a workaround for a lack of user-level item permissions which is something I'd still like to attempt later on in the roadmap. Additionally, encouraging users to potentially create one-off roles where not explicitly needed could lead to performance considerations, especially with large user-counts. Therefore I'm going to close this off, Sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I often create a new role for each user to have granular control over user permissions. This PR makes this easier by adding an option to create a new role on the fly while creating a new user: