Skip to content

Comments

Add reading time to page display#2514

Closed
guillaumehanotel wants to merge 1 commit intoBookStackApp:masterfrom
guillaumehanotel:feature/reading-time
Closed

Add reading time to page display#2514
guillaumehanotel wants to merge 1 commit intoBookStackApp:masterfrom
guillaumehanotel:feature/reading-time

Conversation

@guillaumehanotel
Copy link
Contributor

Hello,

as referred in issue #852, i lay the first stone for this feature by adding a estimated read time below a page title.
Any advice is welcome to help me integrate this feature correctly in the project.

Thank you

@ssddanbrown
Copy link
Member

Thanks for offering this PR @guillaumehanotel, But i think the value of such a feature would really need to be confirmed before inclusion as I'm personally not too convinced in the benefit of this. If BookStack was primarily for articles/blog-posts then maybe this would be ideal for all users otherwise this would need to be configurable visible, which is something I'd prefer to also avoid. Either way, the main page content is generally reserved for content only, no meta data.

I saw you originally had a JS based solution. What might be useful is if you tweak that so it can be added via the "Custom HTML Head Content" setting, then share that on the original issue, so that others can add it to their instance if desired.

@guillaumehanotel
Copy link
Contributor Author

Thank you for your feedback,
I did as you told me and shared my piece of code in the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants