Fixing default config lookup for bookshelves_view_type in BookshelfController#2586
Closed
philjak wants to merge 2 commits intoBookStackApp:masterfrom
Closed
Fixing default config lookup for bookshelves_view_type in BookshelfController#2586philjak wants to merge 2 commits intoBookStackApp:masterfrom
philjak wants to merge 2 commits intoBookStackApp:masterfrom
Conversation
Member
|
Thanks for offering a PR @philjak but this was not a bug or incorrect value used; Those are two different views with two different preference keys. There's currently no |
Author
|
@ssddanbrown Ahh, ok. Sorry. I just recognized that the default behavior changed during the last updates |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A wrong setting key (
bookshelf_view_type) was used. So the configured default in.envwas not used. This PR fixes this issue.How to reproduce:
APP_VIEWS_BOOKSHELVES=listin.envFileExpected: See books as list.
What actually happens: Default grid view is shown.