Skip to content

Fixing default config lookup for bookshelves_view_type in BookshelfController#2586

Closed
philjak wants to merge 2 commits intoBookStackApp:masterfrom
philjak:bugfix_default_bookshelf_view_type
Closed

Fixing default config lookup for bookshelves_view_type in BookshelfController#2586
philjak wants to merge 2 commits intoBookStackApp:masterfrom
philjak:bugfix_default_bookshelf_view_type

Conversation

@philjak
Copy link

@philjak philjak commented Feb 24, 2021

A wrong setting key (bookshelf_view_type) was used. So the configured default in .env was not used. This PR fixes this issue.

How to reproduce:

  • Set APP_VIEWS_BOOKSHELVES=list in .env File
  • Use a new user and open a random bookshelf (/shelves/{slug})

Expected: See books as list.

What actually happens: Default grid view is shown.

@ssddanbrown
Copy link
Member

Thanks for offering a PR @philjak but this was not a bug or incorrect value used; Those are two different views with two different preference keys. There's currently no .env option for the default shelf view option.

@philjak
Copy link
Author

philjak commented Feb 25, 2021

@ssddanbrown Ahh, ok. Sorry. I just recognized that the default behavior changed during the last updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants