Added Sitemap generator#2610
Added Sitemap generator#2610bridgeyuwa wants to merge 8 commits intoBookStackApp:masterfrom bridgeyuwa:master
Conversation
Folder to house sitemap.xml and older generated sitemap versions for reference
Folder to house sitemap.xml and older generated sitemap versions for reference
|
Thanks for offering this PR @bridgeyuwa. Personally I feel this implementation would raise some considerable concerns for me:
Overall, this implementation does not really integrate much with the project itself, You could essentially wrap the library used into another app then run that against your BookStack URL to achieve the same result. Otherwise there are various services/commands to help generate sitemaps in a similar manner. This is one of those features that I don't think there's enough demand to really warrant the build and effort into the project at this stage. Now we have the API, Sitemap generation could be a good use for that for the people that do feel they need it. |
|
OK.. Maybe I'll do it the best I can and see if anyone is willing to help fix/refactor anything that isn't right, e.g redundancy. |
|
@bridgeyuwa Okay, I'd still be worried about introducing a hefty feature, especially since it's not highly requested. It may get quite complex and tricky once you start considering permissions. I've created a simplistic example of using the API to create a sitemap in our API examples repo here: |
|
Wonderful Job well-done How about making the on line 99 ===> |
|
@bridgeyuwa From searching yesterday most sources tended to say the lastmod is generally ingored nowdays, but I've updated the script to use item |
|
This is perfect. |
|
Cool, I'll therefore close off this PR and it's implementation. |
Added a feature which will automatically generate and update sitemap to improve search engine optimization
One step into the SEO optimization of BookStack.