Skip to content

Persian translate#3610

Closed
samadha56 wants to merge 1 commit intoBookStackApp:releasefrom
samadha56:persian_translate
Closed

Persian translate#3610
samadha56 wants to merge 1 commit intoBookStackApp:releasefrom
samadha56:persian_translate

Conversation

@samadha56
Copy link
Contributor

Persian translate at July 30, 2022

@samadha56 samadha56 changed the base branch from development to release July 29, 2022 20:17
@ssddanbrown ssddanbrown added this to the v22.07.1 milestone Aug 2, 2022
@ssddanbrown
Copy link
Member

Thank you for offering these translation updates @samadha56, But I don't be able to directly merge these since they have been written upon the realease branch of BookStack, which is only used for releases, not development.

To merge these changes one of the following options could be chosen:

  • Open a fresh pull request with these changes applied to a fork of the development branch only.
  • Provide me permission to manually transfer these changes to the development branch. You may lose any code/GitHub based attribution in this process though.

Upon the above, translations are mainly managed via Crowdin. This is usually an easier and better option for providing translation content. While I can add translations from PRs, there's a chance the translation content may get lost in the automated sync operations with our primary Crowdin system.

@ssddanbrown ssddanbrown removed this from the v22.07.1 milestone Aug 2, 2022
@samadha56
Copy link
Contributor Author

Thanks for replay,
I pull development branch and translate upon development, then create new pull request:
#3639

now you can close this pull request.

@ssddanbrown
Copy link
Member

Thanks @samadha56, Will therefore close this off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants