Install spatie/laravel-backup for automated & easy backups#3783
Closed
axelrindle wants to merge 2 commits intoBookStackApp:developmentfrom
Closed
Install spatie/laravel-backup for automated & easy backups#3783axelrindle wants to merge 2 commits intoBookStackApp:developmentfrom
axelrindle wants to merge 2 commits intoBookStackApp:developmentfrom
Conversation
Making use of spatie/laravel-backup for this
Member
|
Thanks for offering this @axelrindle! To be honest though, I was hoping for some discussion in regards to the options presented in my #723 comment, before diving into an implementation. |
Member
|
I'm going to go ahead and close this off in favour of exploring options as per my message above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
spatie/laravel-backup is a package for automated backup creation.
The default configuration includes the following data in a backup:
public/uploadsstorage/uploads.envI incorporated the data mentioned in the docs.
This does not add any possibility to create backups from the UI. Backups can be created by running the following Artisan command:
If the user wishes he may create a database-only backup:
I like this package because it lets me create backups with ease and without having to deal with custom scripts. And I'm lazy
¯\_(ツ)_/¯Points to discuss
Configuration
The package is highly configurable and I already changed some of the defaults, for example the following:
https://github.com/axelrindle/BookStack/blob/336bd2204614de3f20016e4eb4dc12e1a113ca26/app/Config/backup.php#L119-L122
In my eyes the biggest point to discuss is: should there be anything else to configure via environment variables? I'd say no to keep the complexity of the config file small.
Restore
The package does not provide the possibility to restore backups which still leaves that up to the user.
I agree with that.
Resources
The packages published a lot of language resources. I'm currently questioning whether they should reside in the application's resources as I don't think there will be any changes to them.
Relations
I read through the comments in #185, #723 and #2405.
Closes #723, closes #2405.