Skip to content

Conversation

@diegoseso
Copy link
Contributor

I have just finished this first approach to get information about missing translations, missing keys on translations array and making a base in general for better managing translations

@ssddanbrown
Copy link
Member

Hey @diegoseso, Thank you for attempting to fix this, Sorry I havn't got back to you sooner.

I've just given it a quick go and it looks great. The 'Pending to define' list looks perfect. Here as some things that would be great to amend before merging in:

  • The 'items defined but pending for a translation' and 'items not longer needed' lists appears to contain the same contents? At least for FR.
  • The script requires the user to run it from the resources/lang folder. It would be great if all directory operations were done relative to the script location (Using __dir__) such as on the first if statement.
  • Since it's a standalone script, having #!/usr/bin/env php on the very first line would make it able to be ran directly via the command line without invoking php manually (./check-translations.php vs php check-translations.php).
  • It would be ideal if the input language casing did not matter, So I could enter fr or FR to check french translations.

@ssddanbrown
Copy link
Member

No longer needed as of b167ae7 therefore closing.

@ssddanbrown ssddanbrown closed this Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants