Skip to content

Update page.blade.php#4479

Closed
Man-in-Black wants to merge 1 commit intoBookStackApp:developmentfrom
Man-in-Black:patch-2
Closed

Update page.blade.php#4479
Man-in-Black wants to merge 1 commit intoBookStackApp:developmentfrom
Man-in-Black:patch-2

Conversation

@Man-in-Black
Copy link
Contributor

Included the page content and the tags from the entity tag-export

Included the page content and the tags from the entity tag-export
@ssddanbrown
Copy link
Member

Thanks for offering but I take a very conservative approach to showing extra information/detail in areas.
I would only really do so upon significant proven requirement/purpose, which I don't feel is proven for these changes.

I'd usually instead advise use of the visual theme system if you do need more that what's provided by default in these templates.

For this reasoning, I'm going to close this PR along with #4478.
If you do think changes should be in the core project then you could raise a feature request to explain the value/purpose but it may be something I close off with similar reasoning to the above.

@Man-in-Black
Copy link
Contributor Author

Ok thats fine by me.
I already did this in the visual theme system and found it quite useful, so I thought that this could maybe find its way to the core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants