Skip to content

Comments

Converting the comment system to Vue.JS#479

Merged
ssddanbrown merged 11 commits intoBookStackApp:masterfrom
Abijeet:master
Sep 2, 2017
Merged

Converting the comment system to Vue.JS#479
ssddanbrown merged 11 commits intoBookStackApp:masterfrom
Abijeet:master

Conversation

@Abijeet
Copy link
Member

@Abijeet Abijeet commented Aug 19, 2017

This might take a week or so to do. Expected date of completion - 27th Aug.

Getting the latest changes.
@Abijeet Abijeet changed the title WIP : Converting the comment system to Vue.JS WIP: Converting the comment system to Vue.JS Aug 19, 2017
@Abijeet
Copy link
Member Author

Abijeet commented Aug 22, 2017

@ssddanbrown - I'm mostly done. I've run some of the test cases, and I'll run some more tomorrow, but this is ready to be merged to the master.

Please give it a look and let me know if you'd like to change anything.

@Abijeet Abijeet changed the title WIP: Converting the comment system to Vue.JS Converting the comment system to Vue.JS Aug 22, 2017
@ssddanbrown ssddanbrown added this to the BookStack Beta v0.18 milestone Sep 2, 2017
@AbijeetP
Copy link
Contributor

AbijeetP commented Sep 2, 2017

@ssddanbrown - Did you get a chance to take a look at this?

@ssddanbrown ssddanbrown merged commit 76ae5c7 into BookStackApp:master Sep 2, 2017
@ssddanbrown
Copy link
Member

@Abijeet Looks good. Will go through this in further detail probably tomorrow morning. All seemed to function well though so I've merged it in.

I've been thinking and might change the system to remove nested comments. Will mean a single, chronological list. Replies would indicate the comment they're replying to with a link. This way there would be no need to have a reply limit. I'll toy with this change tomorrow and see if it works better for a system like BookStack.

@Abijeet
Copy link
Member Author

Abijeet commented Sep 2, 2017

@ssddanbrown - That'll make the code and the system simpler but a little more difficult to read.

To implement this we will have to add a unique hash to each comment (I think that's already being done), so that the user can jump between messages on the page.

It could be done something like this -


In reply to this is the page name (comment)

This is another comment that is a reply to the previous comment.


What do you think?

@ssddanbrown
Copy link
Member

@AbijeetP Yeah, That's along the lines of what I was thinking. I'll have a play about now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants