Converting the comment system to Vue.JS#479
Converting the comment system to Vue.JS#479ssddanbrown merged 11 commits intoBookStackApp:masterfrom Abijeet:master
Conversation
Getting the latest changes.
…testing and load testing.
…testing and load testing.
Conflicts: resources/assets/js/vues/vues.js
|
@ssddanbrown - I'm mostly done. I've run some of the test cases, and I'll run some more tomorrow, but this is ready to be merged to the master. Please give it a look and let me know if you'd like to change anything. |
|
@ssddanbrown - Did you get a chance to take a look at this? |
|
@Abijeet Looks good. Will go through this in further detail probably tomorrow morning. All seemed to function well though so I've merged it in. I've been thinking and might change the system to remove nested comments. Will mean a single, chronological list. Replies would indicate the comment they're replying to with a link. This way there would be no need to have a reply limit. I'll toy with this change tomorrow and see if it works better for a system like BookStack. |
|
@ssddanbrown - That'll make the code and the system simpler but a little more difficult to read. To implement this we will have to add a unique hash to each comment (I think that's already being done), so that the user can jump between messages on the page. It could be done something like this -
This is another comment that is a reply to the previous comment. What do you think? |
|
@AbijeetP Yeah, That's along the lines of what I was thinking. I'll have a play about now. |
This might take a week or so to do. Expected date of completion - 27th Aug.