Add language changing func to tinymce#490
Closed
msaus wants to merge 89 commits intoBookStackApp:masterfrom
msaus:add-language-changing-func-to-tinymce
Closed
Add language changing func to tinymce#490msaus wants to merge 89 commits intoBookStackApp:masterfrom msaus:add-language-changing-func-to-tinymce
msaus wants to merge 89 commits intoBookStackApp:masterfrom
msaus:add-language-changing-func-to-tinymce
Conversation
Also updated assets, Version number
Member
|
Hi @msaus, Thank you for your pull request. There are a few issues here though which mean this cannot be merged. Firstly, You have done this work on the Secondly, This overwrites all existing tinymce config and breaks a lot of existing functionality. The language control needs to be set within the current config rather than being replaced. Additionally, We'd need to include the actual lang files as no translations will actually be used at the moment. |
Contributor
Author
|
Thank you for your suggestions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just added language changing function for tinymce since this is not changed when I select language except for English.