Closes #55. Allows you to set the primary color.#73
Merged
ssddanbrown merged 1 commit intoBookStackApp:masterfrom Mar 6, 2016
Merged
Closes #55. Allows you to set the primary color.#73ssddanbrown merged 1 commit intoBookStackApp:masterfrom
ssddanbrown merged 1 commit intoBookStackApp:masterfrom
Conversation
This certainly should not be seen as the final implementation of this. I imagine that requests like this will happen for many other colors in the system, it might be good at some point to allow them to upload their own stylesheet to be used.
Member
|
@nwalke Thanks again for the pull request. I switched out the color picker library since jscolor is GPLv3 licensed which I believe is not compatible with BookStack's MIT licence. I also moved the color rgb logic from the controller to be calculated on the front-end since the new color picker library had that built in and it keeps the controller cleaner. Now the lighter color shade is sent through as a hidden setting. I totally agree with being able to use own stylesheets but for now the current solution will be very nice for people that don't want to get involved with editing css. At some point soon I'm planning to have a setting to insert any custom content in the head (For styles or things like analytics scripts). |
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This certainly should not be seen as the final implementation of this. I imagine that requests like this will happen for many other colors in the system, it might be good at some point to allow them to upload their own stylesheet to be used. But then again, maybe this suffices.