security(ci): exclude docs/changelog.md + SECURITY-*.md from scan-pr#10
Open
skhaitan wants to merge 1 commit into
Open
security(ci): exclude docs/changelog.md + SECURITY-*.md from scan-pr#10skhaitan wants to merge 1 commit into
skhaitan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Step 4 Bundle 1b — extend the
scan-prexclude list insecurity-precommit.ymlto coverdocs/changelog.md,SECURITY-*.md, andMALWARE-*.md.Why
The case-block in
security-precommit.ymlskips IoC pattern matching for known detection-rule files (e.g..gitleaks.toml,docs/incident-*). It didn't yet cover:docs/changelog.md— every changelog entry references the 2026-04-30 incident IoC strings (_$_1e42,9-3900,Tgw(2509),bsc-dataseed) as part of the changelog narrative. Every PR that adds a changelog entry was failingscan-prfor this reason. Most recently this blocked Sagar's 14 mobile-app endpoint PRs (#936–#955) and Chris's#961.SECURITY-INCIDENT-*.md,SECURITY-AUDIT-*.md,SECURITY-EXCEPTIONS*.md,SECURITY-POSTMORTEM-*.md— same shape; root-level security docs reference incident strings.MALWARE-*.md— same.These are the canonical homes for incident documentation; they should never be flagged by the IoC scanner.
Test plan
scan-prpasses on this PR (which itself modifies.github/workflows/security-precommit.yml— already excluded by the existing.github/workflows/security-*pattern)scan-pr🤖 Generated with Claude Code