Skip to content

Evaluate form class lazily#41

Merged
pyromaniac merged 1 commit into
mainfrom
lazy-form-evaluation
Dec 20, 2023
Merged

Evaluate form class lazily#41
pyromaniac merged 1 commit into
mainfrom
lazy-form-evaluation

Conversation

@pyromaniac
Copy link
Copy Markdown
Contributor

@pyromaniac pyromaniac commented Dec 20, 2023

The previous behavior caused form_class to evaluate before form_base is assigned in some cases.

ston1x
ston1x approved these changes Dec 20, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@ston1x ston1x left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit, thank you!

Comment thread lib/operations/command.rb
@pyromaniac pyromaniac merged commit e1a8973 into main Dec 20, 2023
@pyromaniac pyromaniac deleted the lazy-form-evaluation branch December 20, 2023 10:39
@pyromaniac pyromaniac mentioned this pull request Dec 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ston1x ston1x ston1x approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pyromaniac @ston1x