Can't collapse sidebar

[pierremonico]

Current behavior

When I hit Cmd + B, the sidebar doesn't hide. I also tried with Ctrl + B just in case.

Expected behavior

The sidebar should collapse.

Steps to reproduce

1. Open the app
2. Click on SomeStorageName
3. Click on All Notes
4. Hit Cmd + B (nothing happens)
5. Click inside the editor of a given note
6. Hit Cmd + B (nothing happens)

Environment

• Boostnote version: 0.1.4
• OS version and name: macOS High Sierra, 10.13.6

[Rokt33r]

The feature is not implemented yet. Thanks for the reminding. We'll work this soon!

[pierremonico]

Alright, maybe just remove it from the shortcut list in the meantime then :)

[Flexo013]

@pierremonico What shortcut list?

[arcturus140]

@Flexo013 see tutorial notes...

[pierremonico]

@Flexo013 see tutorial notes...

That's correct.

[Rokt33r]

I re-opened this so I can keep tracking this issue.

[JohnPhamous]

@Rokt33r, are you working on this? If not mind if I take it up? Also saw #333.

[Flexo013]

@JohnPhamous Feel free to take this up!

Note that this one specifically is for hiding the entire sidebar. Check old Boostnote to see the exact behavior.

#333 is for making the sidebar smaller, but still usuable.

[JohnPhamous]

@Flexo013 thanks for clarifying. Are there other docs on how to get started working on the codebase? I tried the instructions under Build in the README but got this error

[ZeroX-DG]

@JohnPhamous You can create an empty .env file in the root folder and run

npm run dev

[Rokt33r]

@pierremonico I think #333 is better. The behavior is almost same but I think showing minimized functional UI is superior. Do you think you need hiding sidebar feature even though we have minimizing sidebar feature? If so, let us know why do you think so!