Skip to content

Feature/add code fence buttons to cloud markdown#1013

Merged
Rokt33r merged 3 commits intoBoostIO:masterfrom
Komediruzecki:feature/add-code-fence-buttons-to-cloud-markdown
Jun 23, 2021
Merged

Feature/add code fence buttons to cloud markdown#1013
Rokt33r merged 3 commits intoBoostIO:masterfrom
Komediruzecki:feature/add-code-fence-buttons-to-cloud-markdown

Conversation

@Komediruzecki
Copy link
Copy Markdown
Contributor

Add code fence to cloud

  • Refactor CodeFence and rehype attacher to shared components
  • Add load mode function to shared codemirror util

Tested in:
Webapp dev (cloud space)
Desktop app dev (cloud and local space)

Tests:

  • try saving snippet (works)
  • try copy/pasting snippet (works)
  • export note with snippets (HTML, PDF, Markdown)
    • works but previous bug with incorrect styles for cloud space (PDF export only) is making code blocks invisible (white text, white background) - should be fixed in another PR

Fix it in cloud and in local space
Also fix weird inifinite rerendering on feeding mime as a string 'null'
Refactor cloud and local space to use the same shared instance of modified codemirror
@Komediruzecki Komediruzecki requested a review from Rokt33r June 20, 2021 11:12
@Rokt33r Rokt33r merged commit 23085e7 into BoostIO:master Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants