Conversation
| import EditorKeyMapSelect from './EditorKeyMapSelect' | ||
| import EditorThemeSelect from './EditorThemeSelect' | ||
| import DocContextMenu from '../../organisms/Topbar/Controls/ControlsContextMenu/DocContextMenu' | ||
| //import DocContextMenu from '../../organisms/Topbar/Controls/ControlsContextMenu/DocContextMenu' |
Contributor
There was a problem hiding this comment.
Should this comment be removed?
| backLinks, | ||
| editorRef, | ||
| }: DocContextMenuProps) => { | ||
| const { permissions = [], currentUserIsCoreMember } = usePage() |
Contributor
There was a problem hiding this comment.
Probably doesn't need to be changes, but this data can probably be passed as props rather than using the hook. team, currentDoc etc is so it feels a bit out of place.
Maybe worth taking a look at if/when we review how we handle API data, as here it seems to actually only be used to ensure most recent version of users, which probably should be done at a higher level.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.