Add last opened page pathname to local storage#1059
Closed
Komediruzecki wants to merge 1 commit intoBoostIO:masterfrom
Closed
Add last opened page pathname to local storage#1059Komediruzecki wants to merge 1 commit intoBoostIO:masterfrom
Komediruzecki wants to merge 1 commit intoBoostIO:masterfrom
Conversation
Add last page pathname to web and desktop cloud space Add last page pathname to local space
Komediruzecki
commented
Jul 22, 2021
| 'lastOpenedPagePathname' | ||
| ) | ||
| if (previousPathname) { | ||
| push(previousPathname) |
Contributor
Author
There was a problem hiding this comment.
Technically this pathname could be invalid, we could check for empty string etc.
If user goes to some pathname which is not saved (but all should be), and for example deletes storage, it might happen that on load it tries to load some 404 pathname and thus giving problems, any ideas how to check if this pathname is at least somewhat correct and if not default to valid options? (maybe parse the pathname contents, check if storage exists, if document exists)
This is especially important in team cloud spaces, as document could be removed from other teammates?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add last page pathname to web and desktop cloud space
Add last page pathname to local space