Add expandable image in markdown preview#1081
Closed
Komediruzecki wants to merge 3 commits intoBoostIO:masterfrom
Closed
Add expandable image in markdown preview#1081Komediruzecki wants to merge 3 commits intoBoostIO:masterfrom
Komediruzecki wants to merge 3 commits intoBoostIO:masterfrom
Conversation
Komediruzecki
commented
Aug 10, 2021
Add display block styles to not mess with its positions Add close enlarged image on clicking dimmed background
Komediruzecki
force-pushed
the
feature/image-actions-md-preview
branch
from
a20330b to
18d7702
Compare
Add full size to modal dialog Update Enlarge image to use modal dialog instead of its own Set new CSS needed for image to show in full
Rokt33r
approved these changes
Aug 24, 2021
Merged
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is also a feature in WebApp but we can remove it from there if needed only in Desktop App.
Usage instructions:
Click on preview image to enlarge it
Click on enlarge button which activates on image hover to enlarge it
Click Escape once in enlarged view to discard it (close)
Click on Close button next to image in top right corner to close the view
Short preview how it works:
https://user-images.githubusercontent.com/18196945/128878278-8c6b770b-e404-486d-a443-b81bb9558bea.mp4