Implement custom font settings#1088
Merged
Rokt33r merged 4 commits intoBoostIO:masterfrom Aug 14, 2021
Merged
Conversation
Add font size and family to Account Preferences Add translations keys and translations for all supported languages for new Settings Update mobile and desktop app code mirror editor to respect font size and font families
Komediruzecki
commented
Aug 12, 2021
| }, | ||
| [setFontSize] | ||
| ) | ||
| useDebounce( |
Contributor
Author
There was a problem hiding this comment.
- Changing font family loses focus after update (not sure why it happens here and not in local space)
@Rokt33r any ideas?
Member
There was a problem hiding this comment.
Should provide key for form item. Otherwise, react think the input element is replaced by a new element so it won't keep the focus
Member
There was a problem hiding this comment.
Our usage of react select might cause the issue.
Rokt33r
requested changes
Aug 14, 2021
| }, | ||
| [setFontSize] | ||
| ) | ||
| useDebounce( |
Member
There was a problem hiding this comment.
Should provide key for form item. Otherwise, react think the input element is replaced by a new element so it won't keep the focus
| ) | ||
|
|
||
| const { settings } = useSettings() | ||
| const fontSize = useMemo(() => { |
Member
There was a problem hiding this comment.
Don't overuse memo hooks for simple getters for primitive types, string, number and boolean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add font size and family to Account Preferences
Add translations keys and translations for all supported languages for new Settings
Update mobile and desktop app code mirror editor to respect font size and font families
Tested in desktop app
Changing font works
Changing font family works
Changing languages shows correct preferences descriptions
Changing font family loses focus after update (not sure why it happens here and not in local space)