Refactor Drag and Drop and implement sidenav and folder view dragging#1089
Merged
Rokt33r merged 1 commit intoBoostIO:masterfrom Aug 19, 2021
Merged
Conversation
Rokt33r
requested changes
Aug 13, 2021
Member
Rokt33r
left a comment
Rokt33r
left a comment
There was a problem hiding this comment.
Dnd doesn't work between folder page and tree view in side navigator.
Komediruzecki
force-pushed
the
feature/dnd-inside-folder-view
branch
from
5016bd6 to
0ff3659
Compare
Add callbacks for dnd functions Update lower level components to use dnd functions Add initial dnd refactor Replace dragged resource with resource saving in transfer data Change APIs across codebase (dragStart, dragEnd, dropOn) Add text/plain data transfer to folder and doc dragg save events
Komediruzecki
force-pushed
the
feature/dnd-inside-folder-view
branch
from
0ff3659 to
155a8a0
Compare
Komediruzecki
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add dnd inside folder view and across sidenav and folder view
Add callbacks for dnd functions
Update lower level components to use dnd functions
Add initial dnd refactor
Replace dragged resource with resource saving in transfer data
Change APIs across codebase (dragStart, dragEnd, dropOn)
Add text/plain data transfer to folder and doc dragg save events
Drag and drop showcase:
2021-08-12.15-52-30.mp4
Tested in desktop app
Current bug (I think already present before)