Skip to content

Add progress bars on move bulk items#1095

Closed
Komediruzecki wants to merge 1 commit intoBoostIO:masterfrom
Komediruzecki:feature/progress-bar-for-multi-select-item-actions
Closed

Add progress bars on move bulk items#1095
Komediruzecki wants to merge 1 commit intoBoostIO:masterfrom
Komediruzecki:feature/progress-bar-for-multi-select-item-actions

Conversation

@Komediruzecki
Copy link
Copy Markdown
Contributor

Add progress bar when moving bulk items in folder view

Test:
In desktop application and web application:
Test moving items
User cannot cancel nor remove the move progress

Short example:

2021-08-16.21-01-57.mp4

@Komediruzecki Komediruzecki requested a review from Rokt33r August 17, 2021 15:19
</LoadingButton>
</div>
</Container>
<>
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed because container has transform and to break out of HTML structure it won't work with fixed positioning, see here: https://stackoverflow.com/questions/2637058/positions-fixed-doesnt-work-when-using-webkit-transform

<Container>
<ProgressBarContainer>
<ProgressItems>
<Spinner />
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Custom spinner with white color since the previous spinner which I copied is not customizable - I would like to make it so.

The other cloud spinner is more versatile, but needs positioning, do you have any suggestions, should I leave it like this or should we use the already available cloud spinner and position it?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use the existing spinner rather than having another spinner.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'll try to position the old spinner, hopefully it will work nicely

<Container>
<ProgressBarContainer>
<ProgressItems>
<Spinner />
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use the existing spinner rather than having another spinner.

@Davy-c
Copy link
Copy Markdown
Contributor

Davy-c commented Aug 25, 2021

Closing and merging
#1109
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants