Add paid export API (PDF/HTML)#1225
Closed
Komediruzecki wants to merge 3 commits intoBoostIO:masterfrom
Closed
Conversation
Add handling of paid vs free users for export Add API calls for PDF/HTML Change Doc Context menu to call API on export Fix title not being encoded Add JSON optional API (for client calls)
Remove export procedures from cloud code
Rokt33r
requested changes
Sep 24, 2021
| settings, | ||
| previewStyle | ||
| ) | ||
| if (usingElectron) { |
Member
There was a problem hiding this comment.
From the paid pdf exporting support, I don't think we need another behavior for exporting pdf and html files. Please make the desktop app also use the same exporting api.
Add spinner on loading the document from backend Remove separation from web and desktop client when downloading PDF
Komediruzecki
changed the title
Rokt33r
approved these changes
Sep 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add handling of paid vs free users for export
Add API calls for PDF/HTML
Change Doc Context menu to call API on export
Fix title not being encoded
Add JSON optional API (for client calls)
Remove export procedures from cloud code
Tested:
Free user (cannot export HTML/PDF)
Pro/Standard user (can export HTML/PDF)
Video showcase of new UI changes:
PDF_PaidUI_Changes_2021-09-25.14-27-35.mp4
Implements: https://github.com/Boostnote/BoostHub/issues/1345