Docopsv2/views managing columns#1314
Merged
Davy-c merged 19 commits intodashboard/newfrom Nov 11, 2021
Merged
Conversation
| update: (value: string[]) => void | ||
| isLoading: boolean | ||
| readOnly: boolean | ||
| isErrored?: boolean |
Contributor
There was a problem hiding this comment.
Is there context for adding this state to all of the Pickers instead of just styling the cell? Is there difficult style clashes etc?
Contributor
Author
There was a problem hiding this comment.
we are essentially displaying the picker style rather than the cell style in the actual cell.
Also, I feel like error states will most likely end up having specific behaviour on pickers based on what we want ( like for example having only a delete option etc.. ) so that could simplify that if we go with it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.