Add query param view for smart view views#1422
Merged
Davy-c merged 3 commits intofeat/default-view-inselectorfrom Jan 18, 2022
Merged
Add query param view for smart view views#1422Davy-c merged 3 commits intofeat/default-view-inselectorfrom
Davy-c merged 3 commits intofeat/default-view-inselectorfrom
Conversation
Rokt33r
requested changes
Jan 5, 2022
| setSelectedViewId(viewToLoad.id) | ||
| } | ||
| } catch (_) { | ||
| // leave selected view as is |
Member
There was a problem hiding this comment.
Please check existence of the view before selecting instead of throwing an error without proper handling.
|
|
||
| const selectViewId = useCallback( | ||
| (id: number) => { | ||
| replace(`?view=${id}`) |
Member
There was a problem hiding this comment.
Is it intended? Is there any reasons to use replace instead of push? I think we should use push so users can switch views by back and forward button of their browser.
Komediruzecki
force-pushed
the
feature/add-smart-view-query
branch
from
cddb8f4 to
05a1639
Compare
Add query view for folder and workspace copy link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add query param view for smart view views
Tested with invalid queries and valid view IDs, like:
http://localhost:3001/testspace/dashboard?view=20after creating the views with those IDs.Tested with folder/workspace as well:
http://localhost:3001/testspace/Sprint-meeting-fDdf3f8586d2004bba9b1bf5df0b423ce2?view=26Short video showcase:
ViewQueryManager_2022-01-04.21-09-05.mp4