Skip to content

initial changes for responsiveness#1458

Merged
Davy-c merged 11 commits intomasterfrom
feat/ux-responsiveness
Jan 31, 2022
Merged

initial changes for responsiveness#1458
Davy-c merged 11 commits intomasterfrom
feat/ux-responsiveness

Conversation

@Davy-c
Copy link
Copy Markdown
Contributor

@Davy-c Davy-c commented Jan 28, 2022

  • fix HMR on dev: moved RouterProvider one step up to keep the state ( prevents reloading on previous page etc..)
  • Remove blocking global data fetch, added loaders to compensate
  • Remove blocking page data fetch, added loaders for ux
  • Remove fetch initial props on pageProps query change but with same pathname ( shallow push )
  • Remove blocking nav initial load check, added loaders in dashboard to compensate
  • Remove obsolete cache in resource page
  • Remove blocking editor data loading
  • Added loader for sidebar tree, breadcrumb, editor load, folder pages..

@Davy-c Davy-c added the wip label Jan 28, 2022
@Davy-c Davy-c removed the wip label Jan 30, 2022
@Davy-c Davy-c added the awaiting review ❇️ Pull request is awaiting a review. label Jan 31, 2022

const commonLoaderSpeed = 6
const commonRadiuses = 6
const Loader = ({ variant, ...props }: LoaderProps) => {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this component. We can use each Loader component directly where it should be placed.
Also, it will make further improvements like code splitting and tree shaking more difficult.

@Davy-c Davy-c merged commit 996929e into master Jan 31, 2022
@Davy-c Davy-c deleted the feat/ux-responsiveness branch January 31, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review ❇️ Pull request is awaiting a review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants