Skip to content

Move to storage after creation #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Davy-c merged 2 commits into from
Dec 17, 2019
Merged

Move to storage after creation #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92242bb
redirect to storage notes after create
Davy-c Dec 17, 2019
ebfa80b
remove unused component
Davy-c Dec 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/components/SideNavigator/SideNavigator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,14 +151,15 @@ export default () => {
submitButtonLabel: 'Create Storage',
onClose: async (value: string | null) => {
if (value == null) return
await createStorage(value)
const storage = await createStorage(value)
push(`/app/storages/${storage.id}/notes`)
}
})
}
}
])
},
[popup, prompt, createStorage]
[popup, prompt, createStorage, push]
)

const { toggleClosed, preferences } = usePreferences()
Expand Down
50 changes: 0 additions & 50 deletions src/components/SideNavigator/StorageCreateForm.tsx
View file
Open in desktop

This file was deleted.

5 changes: 4 additions & 1 deletion src/components/Storage/StorageCreate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import { useTranslation } from 'react-i18next'
import { useDb } from '../../lib/db'
import LoginButton from '../atoms/LoginButton'
import { useToast } from '../../lib/toast'
import { useRouter } from '../../lib/router'

export default () => {
const db = useDb()
Expand All @@ -19,6 +20,7 @@ export default () => {
const { t } = useTranslation()
const [name, setName] = useState('')
const [storageType, setStorageType] = useState<'cloud' | 'local'>('cloud')
const { push } = useRouter()

const user = preferences['general.accounts'][0]

Expand All @@ -28,7 +30,8 @@ export default () => {
// editStoragePage edits cloud storage directly
// update local -> update cloud -> on fail -> revert local
try {
await db.createStorage(name, storageType)
const storage = await db.createStorage(name, storageType)
push(`/app/storages/${storage.id}/notes`)
} catch {
pushMessage({
title: 'Cloud Error',
Expand Down