Conversation
Member
kazup01
commented
Dec 17, 2019
kazup01
commented
Davy-c
reviewed
Dec 17, 2019
| <> | ||
| {prev} | ||
| <div className='separator'>></div> | ||
| <div className='separator'>/</div> |
Contributor
There was a problem hiding this comment.
Let's also use ⁄ instead of /, will prevent some lint errors
Davy-c
reviewed
Dec 17, 2019
|
|
||
| export const sideBarTextColor = ({ theme }: StyledProps) => | ||
| `color: ${theme.sideBarTextColor};` | ||
| export const sideBarTextColor = ({ |
Contributor
There was a problem hiding this comment.
the sidebarTextColor is already used in three components, and the other components have not been adapted to this change.
keep only
export const sideBarTextColor = ({ theme }: StyledProps) =>
`color: ${theme.sideBarTextColor};`
or change the other affected components
Member
Author
There was a problem hiding this comment.
It is okey because UI is natural in other sections.
Davy-c
reviewed
Dec 17, 2019
| export const activeBackgroundColor = ({ theme }: StyledProps) => | ||
| `background-color: ${theme.activeBackgroundColor};` | ||
|
|
||
| export const activeSideBarSecondaryTextColor = ({ theme }: StyledProps) => |
Contributor
There was a problem hiding this comment.
I don't think this is used anywhere
Davy-c
reviewed
Dec 17, 2019
| export const textColor = ({ theme }: StyledProps) => | ||
| `color: ${theme.textColor};` | ||
|
|
||
| export const activeUiTextColor = ({ theme }: StyledProps) => |
Contributor
There was a problem hiding this comment.
I don't think this is used anywhere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.