Skip to content

fixed #218 (WIP)#253

Closed
Jongkeun wants to merge 1 commit intoBoostIO:masterfrom
Jongkeun:fix-218
Closed

fixed #218 (WIP)#253
Jongkeun wants to merge 1 commit intoBoostIO:masterfrom
Jongkeun:fix-218

Conversation

@Jongkeun
Copy link
Copy Markdown
Contributor

@Jongkeun Jongkeun commented Jan 6, 2020

I'm trying to fix #218.

But it doesn't look efficient.
I think we can't give up filteredNotes useMemo.
Because of the navigate operation.

@Rokt33r
Copy link
Copy Markdown
Member

Rokt33r commented Jan 8, 2020

I'll review this pr and share my thought tomorrow.

@Jongkeun
Copy link
Copy Markdown
Contributor Author

Jongkeun commented Jan 8, 2020

Thanks. I hope you get a better idea than this code.

@Rokt33r
Copy link
Copy Markdown
Member

Rokt33r commented Jan 8, 2020

#268 fixed this problem..! Thanks for the trying!

@Rokt33r Rokt33r closed this Jan 8, 2020
@Jongkeun
Copy link
Copy Markdown
Contributor Author

Jongkeun commented Jan 9, 2020

That looks better!

@Jongkeun Jongkeun deleted the fix-218 branch January 9, 2020 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

search focus

2 participants