Skip to content

Fix typo errors for zh_CN#270

Merged
kazup01 merged 2 commits intoBoostIO:masterfrom
hsuanxyz:fix/i18n-zh_CN
Jan 9, 2020
Merged

Fix typo errors for zh_CN#270
kazup01 merged 2 commits intoBoostIO:masterfrom
hsuanxyz:fix/i18n-zh_CN

Conversation

@hsuanxyz
Copy link
Copy Markdown
Contributor

@hsuanxyz hsuanxyz commented Jan 9, 2020

Fix some typo and phrases.

@claassistantio
Copy link
Copy Markdown

claassistantio commented Jan 9, 2020

CLA assistant check
All committers have signed the CLA.

@kazup01 kazup01 merged commit 38ee8c8 into BoostIO:master Jan 9, 2020
@kazup01
Copy link
Copy Markdown
Member

kazup01 commented Jan 9, 2020

Thanks @hsuanxyz !!!

Copy link
Copy Markdown

@hikerpig hikerpig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just my two cents

Comment thread src/lib/i18n/zhCN.ts
'preferences.editorTheme': '编辑器主题',
'preferences.editorFontSize': '编辑器字号',
'preferences.editorFontFamily': '编辑器字体组',
'preferences.editorFontFamily': '编辑器字体粗细',
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该是 '编辑器字体' 吧

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的,这里应该是 '编辑器字体'

Comment thread src/lib/i18n/zhCN.ts
'storage.noStorage': '没有储存档案',
'storage.create': '创建新储存',
'storage.edit': '超级储存',
'storage.edit': '编辑储存',
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

所有的 storage , 作为名词的时候,翻译成 '存储' 是不是更好?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉区别不大,俩者都可以作为名称或动词。
不过结合上下午其实可以省略掉它,但是看其他的 i18n 都保留了所以没省略

@Rokt33r
Copy link
Copy Markdown
Member

Rokt33r commented Jan 9, 2020

@hikerpig Thanks for the review!

@Rokt33r Rokt33r added this to the v0.1.4 milestone Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants